Re-add sync error categories. #6913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # CHANGELOG.md
|
This PR should be ready for review 🙏 |
added 2 commits
August 24, 2023 17:24
…e into cm/sync-error-categories
michael-wb
approved these changes
Aug 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The simplified error reporting removed the sync categories which were used by SDKs to map errors. Without them, SDKs are forced to map each individual sync code introduced which is both error-prone and difficult.
So in order to make this easier this PR is adding back the old categories and adding them to the new error codes.
I tried to compare the old error codes with the new ones and hope I got the categories correct, but it probably requires verification from someone more familiar with the code.